Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OB-525 CSP Changes #161

Merged
merged 12 commits into from
Aug 9, 2023
Merged

Conversation

manjudr
Copy link
Collaborator

@manjudr manjudr commented Aug 9, 2023

This change is related to CSP generalisation

  1. Loading the cloud storage SDK as a Maven dependency
  2. Created an interface to configure the spark CSP configuration
    Ticket - https://project-sunbird.atlassian.net/browse/OB-525

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran the Azure upload file by passing the credentials and the files are able to upload it.
  • Executed the maven build command by passing the Cloud storage SDK as a maven dependency and as a result, we are able to build the artefact.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@manjudr manjudr changed the title OB-525 - CSP Changes OB-525 CSP Changes Aug 9, 2023
Copy link
Collaborator

@anandp504 anandp504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@anandp504 anandp504 merged commit 1c7384b into Sunbird-Obsrv:release-5.1.2 Aug 9, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants